Update slick, slick-hikaricp to 3.4.0

[scala-steward]

Updates

• com.typesafe.slick:slick
• com.typesafe.slick:slick-hikaricp

from 3.3.3 to 3.4.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.typesafe.slick" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.typesafe.slick" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

[ihostage]

Hm... I'm already don't think that it was a good idea 🤔
Because we will be able to have a problem with SLF4J 2.0, that was updated in Slick 3.4.0 (slick/slick#2524)
More details in playframework/playframework#11400
@mkurz Matthias, WDYT? Needs revert this?

[mkurz]

Hmm.. Since this was merged into the main branch, I guess we can keep it. I just diffed the main branch against the latest 5.0.2 release and there is nothing really new in the main branch compared to that last release. What I want to say is, we will use the main branch for the next major release, so it's ok to upgrade slick there, since the 5.0.x branch is basically identical to the master branch, we can still cut new release off the 5.0.x branch without the new play-slick dependency.

[nafg]

Do you think I should roll back slf4j? I guess it would have to be released as 3.4.1. It was careless of me to let it in after the last RC.

[mkurz]

@nafg I see you already in the process of rolling back the change: slick/slick#2543

[nafg]

Pending consensus in slick/slick#2542

(I asked on discord and gitter for people to comment on the issue, to give anyone a chance to object)

[nafg]

That's why I made the PR draft, otherwise Mergify would merge it.

[nafg]

@mkurz can I get some input from (beyond the 👍 you gave on the PR, preferably on slick/slick#2542)?