Migrate to GitHub actions #672
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| name: Check | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| schedule: | ||
| - cron: "0 4 * * *" # Nightly build (@daily) | ||
|
|
||
| concurrency: | ||
| # Only run once for latest commit per ref and cancel other (previous) runs. | ||
| group: ci-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| check-code-style: | ||
| name: Code Style | ||
| uses: playframework/.github/.github/workflows/sbt.yml@v1 | ||
| with: | ||
| cmd: sbt scalafmtCheckAll scalafmtSbtCheck | ||
|
|
||
| check-binary-compatibility: | ||
| name: Binary Compatibility | ||
| uses: playframework/.github/.github/workflows/binary-check.yml@v1 | ||
|
|
||
| check-docs: | ||
| name: Docs | ||
| uses: playframework/.github/.github/workflows/sbt.yml@v1 | ||
| with: | ||
| cmd: sbt docs/scalafmtCheckAll docs/scalafmtSbtCheck docs/test docs/validateDocs | ||
|
|
||
| tests: | ||
| name: Tests | ||
| needs: # Waiting more lightweight checks | ||
| - "check-code-style" | ||
| - "check-binary-compatibility" | ||
| - "check-docs" | ||
| uses: playframework/.github/.github/workflows/sbt-matrix.yml@v1 | ||
| with: | ||
| java: >- | ||
| [ "11", "8" ] | ||
| scala: >- | ||
| [ "2.12.15", "2.13.8" ] | ||
| cmd: sbt ++$SCALA_VERSION test | ||
mkurz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| finish: | ||
| name: Finish | ||
| needs: # Should be last | ||
| - "tests" | ||
| uses: playframework/.github/.github/workflows/rtm.yml@v1 | ||
BillyAutrey marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| name: Publish | ||
|
|
||
| on: | ||
| push: | ||
| tags: ["*"] # Releases | ||
|
There was a problem hiding this comment. One more thing: We should also add |
||
|
|
||
| jobs: | ||
| publish-artifacts: | ||
| name: Publish / Artifacts | ||
| uses: playframework/.github/.github/workflows/publish.yml@v1 | ||
| secrets: | ||
| username: ${{ secrets.SONATYPE_USERNAME }} | ||
| password: ${{ secrets.SONATYPE_PASSWORD }} | ||
| pgp_passphrase: ${{ secrets.PGP_PASSPHRASE }} | ||
| pgp_secret: ${{ secrets.PGP_SECRET }} | ||
BillyAutrey marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ | |
| pull_request_rules: | ||
| - name: Merge PRs that are ready | ||
| conditions: | ||
| - check-success~=/ Ready To Merge$ | ||
| - check-success=typesafe-cla-validator | ||
|
There was a problem hiding this comment. This is not the only thing that needs to be changed in the mergify conf. |
||
| - "#approved-reviews-by>=1" | ||
| - "#review-requested=0" | ||
| - "#changes-requested-reviews-by=0" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the main play repo we never ran nightly builds. And there we ran them because we do enable additional jobs which take a while, so its better to no have them run for each pull request.
I suggest to remove the
schedulesection here and replace it withinstead (so the build will be triggered after merge again, so we should be pretty safe I guess)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, makes sense. I was mainly concerned with placing the Travis badge, and wasn't sure which approach to take to get valid statuses from
main.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the GHA badge? I think it just looks at the last run and that's the status it shows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Well that's easier then. Master runs would fix this, I'll change it.