Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mill build tool support #164

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Add Mill build tool support #164

merged 1 commit into from
Jul 12, 2022

Conversation

sake92
Copy link
Contributor

@sake92 sake92 commented May 26, 2022

Mill recently got the init command for creating giter8 projects (not released yet).
com-lihaoyi/mill#1874

Would be nice to have Mill supported here too.

@sake92 sake92 mentioned this pull request May 26, 2022
Merged
mkurz
mkurz approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkurz mkurz merged commit cf4668c into playframework:2.8.x Jul 12, 2022
@mkurz
Copy link
Member

mkurz commented Jul 12, 2022

@sake92 I did some testing with mill -i init playframework/play-scala-seed.g8 and mill playscalaseed.run and mill playscalaseed.test and it seems to work (I had to add play.http.secret.key to application.conf however, it seems dev mode/run is not supported yet... https://com-lihaoyi.github.io/mill/mill/0.10.4/Plugin_Play.html#_commands_equivalence)

@mkurz
Copy link
Member

mkurz commented Jul 12, 2022

@sake92 Actually, can you add the same to https://github.com/playframework/play-java-seed.g8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sake92 @mkurz