refactor Jackson code to hardcode buffer-recycler #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
force-pushed
the
patch-1
branch
3 times, most recently
from
029724d to
b3f7034
Compare
refactor Jackson code to hardcode buffer-recycler update jackson scalafmt Update JacksonJson.scala compile issue
|
I've used proposed changes to fix performance issues of play-json with latest jackson-core in this commit. Here is a screenshot of top-10 list of improved benchmarks when running with GraalVM JDK 22 on Intel® Core™ i9-13900K CPU having DDR5-4800 RAM using 16 threads (only performance core were enabled):
Here are JMH result comparison pages for that and other JVMs using 16 threads on the same environment: |
pjfanning
commented
Jul 8, 2024
| .builder() | ||
| .asInstanceOf[JsonFactoryBuilder] | ||
| .streamReadConstraints(streamReadConstraints) | ||
| .recyclerPool(JsonRecyclerPools.threadLocalPool()) |
There was a problem hiding this comment.
Jackson 2.17.0 used a very inefficient recycler pool that behaved even worse under heavy load - called 'Lock Free'. Jackson 2.17.1 and 2.17.2 (just released) goes back to ThreadLocalPool as the default. Still maybe a good idea to hardcode its use though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
partial fix for #998
Purpose
What does this PR do?
Background Context
Why did you take this approach?
JsonFactory should be used to create ObjectMappers - not the other way around.
ThreadLocal buffer-recycler is the default up to and including Jackson 2.16. Default was changed in Jackson 2.17 but the way play-json uses Jackson is likely to suffer performance wise with the new default.
You might want to make the buffer-recycler configurable like in apache/pekko-http#519
Upgrading to Jackson 2.15 and above also brings in Jackson's StreamReadConstraints and StreamWriteConstraints.
play-json has its own number parsing checks so I disabled the Jackson check. There are other checks in StreamReadConstraints and StreamWriteConstraints and play-json needs to decide if you want to make them configurable or if you want to disable the Jackson checks.
References
Are there any relevant issues / PRs / mailing lists discussions?