-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.10.x] make ImmutableLinkedHashMap serializable #945
Conversation
have you an idea how I can test the serialization in scala-native. |
I think it is better to just have that test as JVM test in |
play-json/shared/src/main/scala-2.13-/play/api/libs/json/ImmutableLinkedHashMap.scala
Show resolved
Hide resolved
play-json/shared/src/main/scala-2.13-/play/api/libs/json/ImmutableLinkedHashMap.scala
Outdated
Show resolved
Hide resolved
thanks for the tip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be better if a maintainer could have a look
@mkurz can you take a look on this PR |
488577b
to
ff052c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work
@Mergifyio backport main |
✅ Backports have been created
|
[main] make ImmutableLinkedHashMap serializable (backport #945) by @ramazanyich
Pull Request Checklist
Fixes
Fixes #944
Purpose
In order to be able to serialize objects that contain JsObject as a member need to have internal underlying ImmutableLinkedHashMap implement serializable interface