Update sbt to 1.3.3

[scala-steward]

Updates org.scala-sbt:sbt from 1.2.8 to 1.3.3.
Release Notes/Changelog

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: semver-minor

[ignasi35]

Hmmmm, this build needs some attention. I'll look into it:

[error] 	at java.lang.Thread.run(Thread.java:748)

[error] (Omnidoc / updatePlaydocClassifiers) java.lang.IllegalArgumentException: Cannot add dependency 'com.typesafe.play#cachecontrol_2.12;2.0.0-M2' to configuration 'default' of module com.typesafe.play#play-omnidoc$sources_playdoc;2.8.0-M5 because this configuration doesn't exist!

[error] Total time: 8 s, completed Oct 15, 2019 8:17:40 AM

[ignasi35]

Trying to solve:

[error] (Omnidoc / updatePlaydocClassifiers) java.lang.IllegalArgumentException: 
  Cannot add dependency 'com.typesafe.play#cachecontrol_2.12;2.0.0-M2' to configuration
  'default' of module com.typesafe.play#play-omnidoc$sources_playdoc;2.8.0-M5 
  because this configuration doesn't exist!

I moved the adding of dependencies to inside the inConfig() clause:

diff --git a/project/OmnidocBuild.scala b/project/OmnidocBuild.scala
index 05fb46e..b4f0638 100644
--- a/project/OmnidocBuild.scala
+++ b/project/OmnidocBuild.scala
@@ -100,9 +100,9 @@ object OmnidocBuild {
 
   def omnidocSettings: Seq[Setting[_]] =
     projectSettings ++
-    dependencySettings ++
     releaseSettings ++
     inConfig(Omnidoc) {
+      dependencySettings ++
       updateSettings ++
       extractSettings ++
       compilerReporterSettings ++

Which seems to solve the issue (there no failure anymore), but I'm not sure of other side-effects or issues this change may have produced. I still need to investigate in more detail but I'm sharing early for extra eyes to see if this change is correct.

I've introduced a few changes...

[dwijnand]

Doesn't look like a safe change at all. dependencySettings contains a bunch of additions to libraryDependencies and ivyConfigurations += Omnidoc, neither of which makes sense as inConfig-scoped settings. So probably the reason this "fixes it" is (a) it puts the settings in scopes that are never accessed, (b) the effects those settings have aren't asserted in any way in PR validation.

Sadly this needs more attention. @eed3si9n, any ideas why this upgrade broke the build?

[eed3si9n]

It sounds similar to what I fixed in 2015 (sbt/sbt@3a3965b), but it's back? Are you trying to call updateClassifiers against artifact that was published using publishLocal? If so it might be better to switch to publishM2, which should emulate Maven environment better.

[ignasi35]

I forgot about this and as I come back to it I think it is a bit out of my (sbt) league.

[dwijnand]

Duplicate of #110