Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala-parser-combinators 2.1.0 (was 2.0.0) #190

Merged

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-lang.modules:scala-parser-combinators from 2.0.0 to 2.1.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-parser-combinators" } ]

labels: library-update, semver-minor

SethTisue
SethTisue previously approved these changes Oct 13, 2021
@SethTisue
Copy link
Member

er, approved after CI likes it, I mean: #193

@SethTisue SethTisue closed this Nov 1, 2021
@SethTisue SethTisue reopened this Nov 1, 2021
@SethTisue
Copy link
Member

I thought maybe #193 had gotten fixed somehow, but apparently not.

@mkurz mkurz force-pushed the update/scala-parser-combinators-2.1.0 branch from d992c59 to 23e35c3 Compare January 3, 2022 16:40
@SethTisue
Copy link
Member

since this is a minor bump (and not just a patch bump), cachecontrol will need a minor bump as well

@SethTisue
Copy link
Member

oh, I see now that @mkurz made remarks about this over at #167

@SethTisue SethTisue marked this pull request as draft January 3, 2022 17:36
@mkurz mkurz force-pushed the update/scala-parser-combinators-2.1.0 branch from 23e35c3 to 0f06b49 Compare January 3, 2022 18:20
@mkurz
Copy link
Member

mkurz commented Jan 3, 2022

@SethTisue I would like to merge this pull request, cut a 2.2.0 release, create a 2.2.x branch (I also just pushed a 2.1.x one) and on this 2.2.x branch again enable the MiMa checks (I will provide a pr against that 2.2.x branch later).
Are you ok with that?

@mkurz mkurz marked this pull request as ready for review January 3, 2022 18:50
@mkurz mkurz requested a review from SethTisue January 3, 2022 18:54
@mkurz mkurz removed the request for review from SethTisue January 3, 2022 19:29
@mkurz
Copy link
Member

mkurz commented Jan 3, 2022

@SethTisue I am merging and releasing because I want to move on. In case something isn't right for you we can always change things later.

@mkurz mkurz merged commit a5d78b7 into playframework:main Jan 3, 2022
@SethTisue
Copy link
Member

SGTM

@scala-steward scala-steward deleted the update/scala-parser-combinators-2.1.0 branch January 12, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants