Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fov calc and add basics video #260

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fix fov calc and add basics video #260

merged 2 commits into from
Nov 5, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Nov 5, 2024 •
edited
Loading

This PR:

  • fixes the fov factor calculation so the smaller of the two viewport axes fit the object. Previously the larger of the two axes were used.
  • adds a help menu item linking to @simonbethke 's awesome basics video.
Screenshot 2024-11-05 at 15 49 45

@slimbuck slimbuck added the bug Something isn't working label Nov 5, 2024
@slimbuck slimbuck requested a review from a team November 5, 2024 15:35
@slimbuck slimbuck self-assigned this Nov 5, 2024
@slimbuck slimbuck changed the title Fix fov calc Fix fov calc and add basics video Nov 5, 2024
@slimbuck slimbuck merged commit a3cb76e into playcanvas:main Nov 5, 2024
2 checks passed
@slimbuck slimbuck deleted the framing-fix branch November 5, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marklundin marklundin marklundin approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimbuck @marklundin @willeastcott