Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure atom scheme #18

Merged
merged 1 commit into from
Jan 9, 2023
Merged

ensure atom scheme #18

merged 1 commit into from
Jan 9, 2023

Conversation

ruslandoga
Copy link

After elixir-ecto/ecto@03b0597 the scheme might arrive as a string from the passed in URL which would result in an error like

10:58:03.114 [error] GenServer #PID<0.584.0> terminating
** (FunctionClauseError) no function clause matching in Mint.Negotiate.transport_connect/4
    (mint 1.4.2) lib/mint/negotiate.ex:48: Mint.Negotiate.transport_connect("http", "127.0.0.1", 8123, [mode: :passive, transport_opts: [keepalive: true, show_econnreset: true]])
    (clickhousex 0.5.0) lib/clickhousex/protocol.ex:39: Clickhousex.Protocol.connect/1
    (db_connection 2.4.3) lib/db_connection/connection.ex:82: DBConnection.Connection.connect/2
    (connection 1.1.0) lib/connection.ex:622: Connection.enter_connect/5
    (stdlib 3.17.1) proc_lib.erl:226: :proc_lib.init_p_do_apply/3
Last message: nil
State: Clickhousex.Protocol

This PR ensures the scheme passed is an atom.

@ruslandoga ruslandoga merged commit 04f1817 into master Jan 9, 2023
@ruslandoga ruslandoga deleted the atom-scheme branch January 9, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants