Fix issue with shared link auth with /current-visitors and segments requests #5154
+31
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macobo
reviewed
Mar 6, 2025
|
apata
changed the title
apata
force-pushed
the
saved-segments/should-load-on-shared-links
branch
from
27c0396 to
04f613b
Compare
apata
force-pushed
the
saved-segments/should-load-on-shared-links
branch
from
04f613b to
032aa43
Compare
macobo
reviewed
Mar 6, 2025
assets/js/dashboard/api.ts
Outdated
| @@ -15,7 +15,7 @@ export class ApiError extends Error { | |||
| } | |||
| } | |||
|
|
|||
| function serialize(obj: Record<string, string | boolean | number>) { | |||
| export function serialize(obj: Record<string, string | boolean | number>) { | |||
There was a problem hiding this comment.
Given we now export this, the name is kind of hard to grok.
Suggested change
| export function serialize(obj: Record<string, string | boolean | number>) { | |
| export function serializeUrlParams(params: Record<string, string | boolean | number>): string { |
macobo
approved these changes
Mar 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Manually tested
Changelog
Documentation
Dark mode