Improve dashboard main graph - revenue metrics, nulls #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has no effect on existing APIs as: - Comparisons/empty data point logic only affects APIv1 which does not expose revenue metrics Also changes semantics for visit_duration to be more in-line with the rest.
- Graph tooltip for revenue metrics now shows revenue with the relevant monetary unit. - Graph tooltips for scroll depth, visit duration and so on now shows `-` instead of 0 on dates where no relevant visits occurred.
ukutaht
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves main graph by:
-instead of0for visit duration, scroll depth when hovering a data point with no visit dataThis is preparatory work for new time-on-page metric (which will be graphable).