Resolve segment owner names and dates in site timezone in the BE #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
saved-segments/resolve-owner-be
branch
from
863994f to
30a99fc
Compare
|
apata
force-pushed
the
saved-segments/resolve-owner-be
branch
from
dc61813 to
06e782f
Compare
ukutaht
approved these changes
Feb 27, 2025
| @@ -14,11 +14,24 @@ export type SavedSegment = { | |||
| id: number | |||
| name: string | |||
| type: SegmentType | |||
| owner_id: number | |||
| /** null owner_id or owner_name signifies that the owner has been removed from the site */ | |||
| owner_id: number | null | |||
There was a problem hiding this comment.
I don't have much experience with typescript types but would something like this be possible?
owner: {id: number, name: string} | null
?
This would disallow the following invalid state at the type level:
{
owner_id: 123,
owner_name: null
}
There was a problem hiding this comment.
True, that state is invalid and I've updated the type definitions to reflect that: 26b136a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Changelog
Documentation
Dark mode