Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve build failure #4586

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Solve build failure #4586

merged 1 commit into from
Sep 17, 2024

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Sep 17, 2024

Building Dockerfile seems to be failing now with the following error:

Dockerfile:72
--------------------
  70 |       && if [ "$MIX_ENV" = "ce" ]; then apk add --no-cache certbot; fi
  71 |
  72 | >>> COPY --from=buildcontainer --chmod=a+rX /app/_build/${MIX_ENV}/rel/plausible /app
  73 |     COPY --chmod=755 ./rel/docker-entrypoint.sh /entrypoint.sh
  74 |
--------------------
ERROR: failed to solve: invalid chmod parameter: 'a+rX'. it should be octal string and between 0 and 07777

Link: https://github.com/plausible/analytics/actions/runs/10898788870/job/30242872415

Not sure why given this line hasn't changed in ages, but perhaps something to do with buildx changes. If preview deploy succeeds in this, it should fix the issue.

From @zoldar:

moby/buildkit#5322 seems like non-octal chmod wasn't accepted before either but was just silently ignored?
moby/buildkit#5148 the change that started validating chmod, fwiw

Not confident this won't cause issues if the previous default that buildx used was 777.

Building Dockerfile seems to be failing now with the following error:
```
Dockerfile:72
--------------------
  70 |       && if [ "$MIX_ENV" = "ce" ]; then apk add --no-cache certbot; fi
  71 |
  72 | >>> COPY --from=buildcontainer --chmod=a+rX /app/_build/${MIX_ENV}/rel/plausible /app
  73 |     COPY --chmod=755 ./rel/docker-entrypoint.sh /entrypoint.sh
  74 |
--------------------
ERROR: failed to solve: invalid chmod parameter: 'a+rX'. it should be octal string and between 0 and 07777
```

Link: https://github.com/plausible/analytics/actions/runs/10898788870/job/30242872415

Not sure _why_ given this line hasn't changed in ages, but perhaps
something to do with buildx changes. If preview deploy succeeds in this,
it should fix the issue.
@macobo macobo added the preview label Sep 17, 2024
Copy link

Preview environment👷🏼‍♀️🏗️
PR-4586

@macobo macobo requested a review from cnkk September 17, 2024 08:09
@zoldar zoldar marked this pull request as ready for review September 17, 2024 09:16
@zoldar zoldar added this pull request to the merge queue Sep 17, 2024
Merged via the queue into master with commit dd1313f Sep 17, 2024
11 checks passed
@macobo macobo deleted the chmod-failure branch September 17, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants