Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelpScout integration #4327

Merged
merged 11 commits into from
Jul 12, 2024
Merged

HelpScout integration #4327

merged 11 commits into from
Jul 12, 2024

Conversation

zoldar
Copy link
Contributor

@zoldar zoldar commented Jul 9, 2024

Changes

This PR implements HelpScout integration making easier to asses customer state directly from HS dashboard.

Once reviewed, the migration will be eventually split out from this PR and deployed before the rest.

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@zoldar zoldar changed the title Hs integration HelpScout integration Jul 9, 2024
@zoldar zoldar force-pushed the hs-integration branch 13 times, most recently from ae02a2e to 1bae368 Compare July 11, 2024 08:41
@zoldar zoldar added deploy-to-staging Special label that triggers a deploy to a staging environment preview labels Jul 11, 2024
Copy link

Preview environment👷🏼‍♀️🏗️
PR-4327

@zoldar zoldar marked this pull request as ready for review July 11, 2024 10:11
@zoldar zoldar requested a review from a team July 11, 2024 10:11
Copy link
Member

@aerosol aerosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

NOTE: HelpScout signature generation procedure at
https://developer.helpscout.com/apps/guides/signature-validation/
fails to mention that it's implicitly dependent on request params
order getting preserved. PHP arrays are ordered maps, so they provide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyrranic

@zoldar zoldar changed the base branch from master to hs-integration-migration July 12, 2024 08:57
Base automatically changed from hs-integration-migration to master July 12, 2024 09:35
@zoldar zoldar merged commit 1c5c4a2 into master Jul 12, 2024
10 checks passed
@zoldar zoldar deleted the hs-integration branch July 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-to-staging Special label that triggers a deploy to a staging environment preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants