Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe the changes made in the pull request here.
Below you'll find a checklist. For each item on the list, check one option and delete the other.
Tests
Changelog
Documentation
This is a first approach for allowing multiple accounts to access a site. This adds:
admin
orviewer
) to site memberships and makes the current owner an admin.Unfortunately I currently don't have a time to continue working on this, but don't want it go to waste. Also, the more I work on this the larger the impact this feature has on the application and I can't make these decisions.
Some things to consider when adding access of multiple accounts to a site:
What is still missing:
My recommendation would also be to split up the SettingsController into different modules. A lot of logic is currently embedded in the controller which might make it difficult to test and maintain.