use nimble_csv everywhere #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Jun 4, 2024
| @@ -154,6 +154,7 @@ defmodule PlausibleWeb.StatsController do | |||
| Map.keys(csvs) | |||
| |> Enum.zip(csv_values) | |||
| |> Enum.reject(fn {_k, v} -> is_nil(v) end) | |||
| |> Enum.map(fn {k, v} -> {k, IO.iodata_to_binary(v)} end) | |||
|
|
|||
| {:ok, {_, zip_content}} = :zip.create(filename, csvs, [:memory]) | |||
There was a problem hiding this comment.
note to self: :zip.create doesn't support iodata, maybe it makes sense to use zstream here and send the export in chunks.
|
Hey @ruslandoga I'd like to merge this if possible. Why is it in draft status? |
|
The main reason is that I thought it would improve performance by using iolists but it turned out to be impossible since |
|
I'll rebase the PR and remove the Draft tag. |
ruslandoga
force-pushed
the
use-nimble-csv
branch
from
bce6831 to
62cf5fb
Compare
|
ukutaht
approved these changes
Jul 16, 2024
|
CSV export worked for https://pr-4183.review.plausible.io/dummy.site |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR replaces https://github.com/beatrichartz/csv with https://github.com/dashbitco/nimble_csv as a more performant option (fewer binaries are created this way)
Tests
Changelog
Documentation
Dark mode