fix manual embed width #3910
Merged
fix manual embed width #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Mar 17, 2024
| @@ -42,7 +42,7 @@ defmodule PlausibleWeb.StatsView do | |||
|
|
|||
| def stats_container_class(conn) do | |||
| cond do | |||
| conn.assigns[:embedded] && conn.assigns[:width] == "manual" -> "" | |||
There was a problem hiding this comment.
There was no such assign. I thought about adding it but was afraid that it's used someplace else in the template. So instead I'm just checking the params.
ruslandoga
commented
Mar 17, 2024
| @@ -42,7 +42,7 @@ defmodule PlausibleWeb.StatsView do | |||
|
|
|||
| def stats_container_class(conn) do | |||
| cond do | |||
| conn.assigns[:embedded] && conn.assigns[:width] == "manual" -> "" | |||
| conn.assigns[:embedded] && conn.params["width"] == "manual" -> "px-6" | |||
There was a problem hiding this comment.
I'm still adding padding since it looks much nicer that way.
zoldar
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes plausible/docs#470
Here's how it looks in
bg-red-200 mx-auto max-w-mdcontainerAnd here's how it looks in
bg-red-200containerAnd here's how it looks on master (where
max-w-screen-xlwas applied regardless ofwidth=manual)Tests
Changelog
Documentation
Dark mode