Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weekday to the visitor graph #386

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Add weekday to the visitor graph #386

merged 2 commits into from
Oct 29, 2020

Conversation

chadwhitacre
Copy link
Contributor

Closes #175.

Changes

Abbreviate both weekday and month in order to keep horizontal spacing roughly the same as it's been.

Tests

  • This PR does not require tests - I skimmed the test suite and didn't find any FE tests

Changelog

  • Entry has been added to changelog

Documentation

Abbreviate both weekday and month in order to keep horizontal spacing
roughly the same as it's been.

Closes #175.
@chadwhitacre
Copy link
Contributor Author

NB: I did not test this manually because I didn't want to spend the time getting a full local setup in place. If you need me to go down the rabbit hole let me know.

@ukutaht
Copy link
Contributor

ukutaht commented Oct 29, 2020

Fair enough, I'll give it a go and let you know

@chadwhitacre
Copy link
Contributor Author

Thanks @ukutaht. :)

@ukutaht
Copy link
Contributor

ukutaht commented Oct 29, 2020

LGTM. I won't update screenshots for now because it's such a small change

Screenshot 2020-10-29 at 15 42 29

@ukutaht ukutaht merged commit 73375b8 into plausible:master Oct 29, 2020
@chadwhitacre chadwhitacre deleted the weekday-on-visitor-graph branch October 29, 2020 13:59
@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Oct 29, 2020

Saweet! Thanks! 💃   How often do you ship to prod?

@chadwhitacre
Copy link
Contributor Author

😍 💃

Screen Shot 2020-10-29 at 12 42 24 PM

@metmarkosaric
Copy link
Contributor

Live now! I'll see to announce it on social media too perhaps tomorrow. Thanks for your contribution @chadwhitacre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diplay the day of the week on chart x-axis labels
3 participants