Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds ability to add metadata to custom events. Technically it prepares the database for the ability to also add metadata to pageviews since pageviews and events share the same schema (#320).
Interestingly, in one issue this feature is called 'metadata' and in another, it's called 'custom dimensions'. I've went with 'metadata' for now but I'm curious to hear everyone's thoughts on naming this feature.
Currently the tracker only exposes a way to add metadata to custom events through the following API:
In the dashboard, this can be interacted with in two possible ways:
Complete Signup
andSignup.variant is A
Tests
Changelog
Documentation