Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weekly/monthly report e-mails (MJML) #3150

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Fix weekly/monthly report e-mails (MJML) #3150

merged 3 commits into from
Jul 17, 2023

Conversation

aerosol
Copy link
Member

@aerosol aerosol commented Jul 17, 2023 •
edited
Loading

Changes

This change attempts to address the issues reported in #284

The PR introduces MJML compiler, via new dependency: https://github.com/akoutmos/mjml_eex using the rust backend at runtime.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@aerosol aerosol added the deploy-to-staging Special label that triggers a deploy to a staging environment label Jul 17, 2023
@bundlemon
Copy link

bundlemon bot commented Jul 17, 2023 •
edited
Loading

BundleMon

Unchanged files (7)
Status Path Size Limits
✅ static/css/app.css
 492.34KB -
✅ static/js/dashboard.js
 318.21KB -
✅ static/js/app.js
 40.1KB -
✅ static/js/embed.host.js
 5.58KB -
✅ static/js/embed.content.js
 5.08KB -
✅ tracker/js/plausible.js
 742B -
✅ static/js/applyTheme.js
 314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@aerosol aerosol changed the title [wip] Try MJML Fix weekly/monthly report e-mails (MJML) Jul 17, 2023
@aerosol aerosol requested a review from ukutaht July 17, 2023 11:37
@aerosol aerosol mentioned this pull request Jul 17, 2023
Closed
8 tasks
@aerosol aerosol requested review from vinibrsl and RobertJoonas July 17, 2023 11:48
RobertJoonas
RobertJoonas approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@RobertJoonas RobertJoonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!

lib/plausible_web/mjml/templates/weekly_report.mjml.eex
@@ -0,0 +1,181 @@
<mjml>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From 697 lines of code to 181. Looking good! 🙌

@aerosol aerosol merged commit e6996cc into master Jul 17, 2023
@aerosol aerosol deleted the mjml-test branch July 17, 2023 14:59
@aerosol aerosol mentioned this pull request Jul 18, 2023
Closed
1 task
@ruslandoga ruslandoga mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertJoonas RobertJoonas RobertJoonas approved these changes

@ukutaht ukutaht Awaiting requested review from ukutaht

@vinibrsl vinibrsl Awaiting requested review from vinibrsl

Assignees
No one assigned
Labels
deploy-to-staging Special label that triggers a deploy to a staging environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aerosol @RobertJoonas