Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the country filter label when clicking on a country on the map #3109

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

krisbuist
Copy link
Contributor

@krisbuist krisbuist commented Jul 5, 2023

Changes

Fixes the bug as described in #3086
The filter label takes the value from the country_labels field and not country_name.
By changing the property to country_labels, the correct name shows up in the filter

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

@bundlemon
Copy link

bundlemon bot commented Jul 11, 2023

BundleMon

Files updated (3)
Status Path Size Limits
static/js/app.js
40.08KB (-17B -0.04%) -
static/js/embed.content.js
5.06KB (-17B -0.33%) -
static/js/dashboard.js
317.47KB (-150B -0.05%) -
Unchanged files (4)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/embed.host.js
5.58KB -
tracker/js/plausible.js
742B -
static/js/applyTheme.js
314B -

Total files change -181B -0.02%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@aerosol
Copy link
Member

aerosol commented Jul 11, 2023

Nice @krisbuist, thank you!

@aerosol aerosol merged commit c4316d6 into plausible:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants