Reject unknown imported cities from queries #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where the city report returned `N/A` entries. The functions that build imported data queries were using SQL `COALESCE`, assuming city data is `NULL` when unknown, when actually its unknown value is `0`. This commit addresses the problem using SQL `NULLIF` combined with the previous `COALESCE` call. With this change both `0` and `NULL` are treated as unknown. Since 1cb07ef cities can be `NULL`, but previously we saved `0` as unknown. Closes #1960
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
vinibrsl
commented
Feb 14, 2023
| @@ -287,8 +290,8 @@ defmodule Plausible.Stats.Imported do | |||
|
|
|||
| :city -> | |||
| q | |||
| |> select_merge([i, s], %{ | |||
| city: fragment("coalesce(?, ?)", s.city, i.city) | |||
| |> select_merge([s, i], %{ | |||
There was a problem hiding this comment.
Bindings were in incorrect order :thisisfine:
vinibrsl
force-pushed
the
reject-null-imported-cities
branch
from
cdb61dd to
a4097c4
Compare
ukutaht
approved these changes
Feb 15, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit fixes a bug where the city report returned
N/Aentries. The functions that build imported data queries were using SQLCOALESCE, assuming city data isNULLwhen unknown, when actually its unknown value is0.This commit addresses the problem using SQL
NULLIFcombined with the previousCOALESCEcall. With this change both0andNULLare treated as unknown.Since 1cb07ef cities can be
NULL, but previously we saved0as unknown.Closes #1960
Tests
Changelog
Documentation
Dark mode