Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty list when breaking down by event:page without events #2530

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

vinibrsl
Copy link
Contributor

Changes

This commit fixes a bug with pagination where breaking down by event:page would always return results despite pagination.

Closes #2255

Tests

  • Automated tests have been added

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@vinibrsl vinibrsl requested a review from a team December 19, 2022 10:35
@bundlemon
Copy link

bundlemon bot commented Dec 19, 2022

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
515.19KB -
static/js/dashboard.js
297.95KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ukutaht
Copy link
Contributor

ukutaht commented Dec 19, 2022

I think a changelog entry under the Fixed category would suit this well

This commit fixes a bug with pagination where breaking down by event:page
would always return results despite pagination.

Closes #2255
@vinibrsl vinibrsl force-pushed the fix-breakdown-event-page-pagination branch from 24301cb to 3dd73ef Compare December 19, 2022 12:42
@vinibrsl vinibrsl merged commit 0e87b48 into master Dec 19, 2022
@vinibrsl vinibrsl deleted the fix-breakdown-event-page-pagination branch December 19, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats API incorrect pagination of results when fetching all metrics
2 participants