Fix missing 'pageviews' column from 'pages.csv' #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashaafm
force-pushed
the
add-pageviews-to-pages-csv
branch
from
2996d6c to
42c7623
Compare
|
oh nice! thanks for your contribution @sashaafm! |
ukutaht
approved these changes
Jul 12, 2022
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The goal of this PR is to fix the missing
pageviewscolumn on the generatedpage.csvfile. Mainly the solution is just adding thepageviewsheader to be added into the CSV and fix some tests.Tests
Changelog
Documentation
From what I can see the only mention of CSV in the docs is here and the
pageviewscolumn is shown although its for thevisitors.csv.Dark mode