Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mobile graph #1160

Merged
merged 9 commits into from
Jun 28, 2021
Merged

Conversation

MaybeThisIsRu
Copy link
Contributor

Changes

This solves the "The traffic numbers on the main chart get squeezed and overlap" issue in #972. Unsure if this requires any tests?

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

* This change adds two new commands to gracefully stop and remove the Postgres and Clickhouse docker containers. To do so, it also gives them a recognizable name.

* Additionally, the Postgres container is updated to use a named volume for its data. This lower friction for repeat contributions where one would otherwise sign up and activate their accounts again and again each time.
@ukutaht
Copy link
Contributor

ukutaht commented Jun 28, 2021

I'm just testing this and while I can reproduce the issue on an older version of the dashboard, I cannot seem to reproduce the issue on the current version of the dashboard. I upgraded from Chart.js v2 to v3 between the two versions so it's possible that it just fixed itself.

@hirusi Can you reproduce on the current live demo?

@metmarkosaric
Copy link
Contributor

i just tested it and it looks fine both on firefox and brave for me. seems like this one is all sorted now

@MaybeThisIsRu
Copy link
Contributor Author

MaybeThisIsRu commented Jun 28, 2021

Hmm, @ukutaht is right at first glance @metmarkosaric. I tested staging and production, and production seems fine.

I'll check locally without my fix but latest master and report back.

@MaybeThisIsRu
Copy link
Contributor Author

MaybeThisIsRu commented Jun 28, 2021

Right - I just tested this locally on the latest master without my fix, and there are no issues on the Y axis:

image

If there is any interest in reducing the clutter on the X axis, this PR will be helpful.

X axis with this fix and Last 30 days selected:

image

X axis without this fix and Last 30 days selected:

image


If X axis is not a concern, I think we can close this PR.

@ukutaht
Copy link
Contributor

ukutaht commented Jun 28, 2021

@hirusi I prefer it with your fix, it's cleaner and more readable. Thanks!

@ukutaht ukutaht merged commit e5a4b82 into plausible:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants