Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invitations #1122

Merged
merged 33 commits into from
Jun 16, 2021
Merged

Invitations #1122

merged 33 commits into from
Jun 16, 2021

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Jun 11, 2021

Changes

See discussion #176

Basic collaboration features to start out with:

  • Site has one owner who is responsible for billing.
  • Owner can invite other users to a site by email address. Members can be admin or viewer
  • Admins can access site settings, viewers can only see the stats
  • The owner can also choose to transfer ownership to another account

This is still under construction. TODO:

  • Ownership transfer email flow (both to the old and new owner)
  • What happens when trying to invite a person who is already a member?
  • Things look weird when I get anownership transfer request while I'm already a member
  • Danger zone should be only for owners
  • Consider role in API access
  • Make sure the site lockout job is running
    • Should lock-checking also happen in webhooks?
  • Expire invitations after 48h

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • Docs have been updated

@ukutaht ukutaht marked this pull request as ready for review June 16, 2021 08:18
@ukutaht ukutaht merged commit e71de6d into master Jun 16, 2021
@ukutaht ukutaht deleted the invitations branch June 16, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant