Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The debugger starts slowly when there is a lot of network traffic #66

Closed
symbiont-stevan-andjelkovic opened this issue Jan 27, 2021 · 0 comments · Fixed by #81
Closed

The debugger starts slowly when there is a lot of network traffic #66

symbiont-stevan-andjelkovic opened this issue Jan 27, 2021 · 0 comments · Fixed by #81
Assignees
@symbiont-daniel-gustafsson

Comments

@symbiont-stevan-andjelkovic
Copy link
Contributor

The sequence diagrams shown in the debugger are generated by calling plantuml once per network event. All these calls are done at the start of the debugger, which creates a slowdown if there are many network events.

Possible solutions:

  1. Generate the sequence diagrams lazily on demand;
  2. Generate the diagrams in the background somehow, outside of the debugger;
  3. Use something faster/draw our own diagrams.
symbiont-daniel-gustafsson added a commit that referenced this issue Feb 1, 2021
@symbiont-daniel-gustafsson
perf(debugger): Implement our own sequence diagrams
0c5e103 
Calling `plantuml` is really slow (probably because it is java application and
java boot is slow), so this commit replaces that with our own sequence diagram
drawing code. It should be reasonable feature complete with what we had before,
but it should take significantly less time to compute the diagrams, and
therefore also boot the debugger.

The diagrams are drawn in a lazy fashion, where we only draw the diagram if it
is looked at. This might not really be needed since we draw them so fast, but I
already had the code for when I was trying to get `plantuml` to work that I
decided to keep it.

closes #66
Merged
symbiont-daniel-gustafsson added a commit that referenced this issue Feb 1, 2021
@symbiont-daniel-gustafsson
perf(debugger): Implement our own sequence diagrams
cc4e1fd 
Calling `plantuml` is really slow (probably because it is java application and
java boot is slow), so this commit replaces that with our own sequence diagram
drawing code. It should be reasonable feature complete with what we had before,
but it should take significantly less time to compute the diagrams, and
therefore also boot the debugger.

The diagrams are drawn in a lazy fashion, where we only draw the diagram if it
is looked at. This might not really be needed since we draw them so fast, but I
already had the code for when I was trying to get `plantuml` to work that I
decided to keep it.

closes #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@symbiont-daniel-gustafsson symbiont-daniel-gustafsson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(debugger): Implement our own sequence diagrams platonic-io/detsys-testkit
2 participants
@symbiont-stevan-andjelkovic @symbiont-daniel-gustafsson