Skip to content

Commit

Permalink
failure to close a conversation makes the action fail
Browse files Browse the repository at this point in the history
  • Loading branch information
renefritze committed Mar 20, 2024
1 parent 2869250 commit d8d04b0
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion run_action.py
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,10 @@ def conversation_threads_to_close(repo, pr_number, github_token, github_api_time
yield thread
break
else:
print("Error getting unresolved conversation threads:", response.status_code)
print(
f"::error::getting unresolved conversation threads: {response.status_code}"
)
raise RuntimeError("Failed to get unresolved conversation threads.")


def close_conversation(thread_id, github_token, github_api_timeout):
Expand Down Expand Up @@ -609,6 +612,7 @@ def close_conversation(thread_id, github_token, github_api_timeout):
"::error:: Failed to close conversation. See log for details and"
"https://github.com/platisd/clang-tidy-pr-comments/blob/master/README.md for help"
)
raise RuntimeError("Failed to close conversation.")


def resolve_conversations(github_token, repo, pull_request_id, github_api_timeout):
Expand Down

0 comments on commit d8d04b0

Please sign in to comment.