Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove project.domain.* activity references #4336

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Remove project.domain.* activity references #4336

merged 2 commits into from
Jan 10, 2025

Conversation

raupie
Copy link
Contributor

@raupie raupie commented Jan 10, 2025

Why

Domains are attached to Environments, not Projects. The project.domain.* is no longer relevant.

What's changed

In order to list domain add, update or delete activity events, you must target the environment activity.

Where are changes

Updates are for:

  • platform (sites/platform templates)
  • upsun (sites/upsun templates)

@chadwcarlson chadwcarlson added the build-fork To build PRs from forks label Jan 10, 2025
chadwcarlson
chadwcarlson approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@chadwcarlson chadwcarlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raupie !

@chadwcarlson chadwcarlson merged commit 0692ac4 into platformsh:main Jan 10, 2025
16 checks passed
@raupie raupie deleted the activity-reference-domain-events branch January 27, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadwcarlson chadwcarlson chadwcarlson approved these changes

Assignees
No one assigned
Labels
build-fork To build PRs from forks markdown/prose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raupie @chadwcarlson @platformsh-devrel