Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrong entry #997

Closed
wants to merge 1 commit into from
Closed

Remove wrong entry #997

wants to merge 1 commit into from

Conversation

Jason2866
Copy link
Contributor

@Jason2866 Jason2866 commented Jan 11, 2023 •
edited
Loading

Fix #996

hamishcunningham
hamishcunningham approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@hamishcunningham hamishcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx Jason, that works for me :)

@valeros valeros closed this in 6660f2c Jan 11, 2023
@Jason2866 Jason2866 deleted the patch-1 branch January 11, 2023 19:31
@Gspohu
Copy link

Gspohu commented Apr 12, 2024 •
edited
Loading

Sorry to dig up, but this issue bring me here :
#996

I face the same problem, so the issue isn't fixed, and this PR was closed. Can someone explain why ?

I can confirm that the fix proposed in the PR, works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishcunningham hamishcunningham hamishcunningham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

partitions.csv default not being found for Adafruit ESP32S3 Feather in version 5.03
3 participants
@Jason2866 @Gspohu @hamishcunningham