Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML Key Sort Trying to Update Nested Keys Based on Priority Sort #982

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

pjkaufman
Copy link
Collaborator

@pjkaufman pjkaufman commented Dec 12, 2023

Fixes #899

There was an issue where using a Priority Sort that had the same name as a nested key could cause it to be pulled out of the YAML if it preceded other keys with the same name that were not nested

Changes Made:

  • Made sure to only try to sort a key if it is a key at the base of the YAML
  • Made sure that we only pull back keys that are at the base of the YAML
  • Added main.zip to git ignore since I accidentally committed it at one point
  • Added wording clarification to make it clearer that nested keys are not to be sorted

@pjkaufman pjkaufman added bug Something isn't working yaml YAML related issues or features labels Dec 12, 2023
@pjkaufman pjkaufman self-assigned this Dec 12, 2023
@pjkaufman pjkaufman merged commit 5240ee7 into platers:master Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working yaml YAML related issues or features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: YAML key priority sort moves keys out of objects
1 participant