Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refocus on Editor After Custom Commands Run #972

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #969

There was an issue where running custom commands was causing an issue where if you had lint on file change on, it would not have the cursor in the new file.

Changes Made:

  • Made sure to deactivate lint on file change when we programatically change the active file and renable it afterwards
  • Got the active editor to determine where to focus once the custom commands run
  • Cleaned up unused logic in the integration logic
  • Added the base level data.json to help see when the base data.json has changed as this affects the ability to do integration tests

…e to remove the test callback if original text is null and it tries to run, added logic for go back to the previously active editor after custom lint, disable lint on change file change during this process, and add data json to make sure the default is present and make it easy to tell when it has been changed
@pjkaufman pjkaufman added bug Something isn't working obsidian Obsidian specific syntax issue or feature labels Dec 10, 2023
@pjkaufman pjkaufman self-assigned this Dec 10, 2023
@pjkaufman pjkaufman merged commit 912a0bf into platers:master Dec 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Since release 1.21.0, switching notes results in a loss of focus of the editor
1 participant