Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sure Blockqoute Style Gets Rid of Multiple Spaces for Blockquote Indicators when Set to Space #965

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #961

The logic for Blockquote Style was only adding missing spaces when the style was Space. This changes that to make it so that multiple spaces/tabs get cut down to just 1 space.

Changes Made:

  • Added tests for multiple spaces, tabs, and a combination of spaces and tabs
  • Added regex to take blockquote indicators followed by 2 or more spaces and or 1 or more tabs down to 1 space
  • Fixed a bug with offsetting new line character positioning based on start of line differences in sizes that only mattered when nesting had lots of characters and text was small

pjkaufman and others added 3 commits December 6, 2023 14:30
…ds, but worked due to a lack of nesting tests and made sure that any number of tabs and 2 or more spaces plus tabs get converted to spaces as part of the start of a line for blockquotes
@pjkaufman pjkaufman added bug Something isn't working enhancement New feature or request markdown General Markdown or Markdown related issue or feature labels Dec 6, 2023
@pjkaufman pjkaufman self-assigned this Dec 6, 2023
@pjkaufman pjkaufman merged commit 5dcb0de into platers:master Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request markdown General Markdown or Markdown related issue or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Ensure single space after blockquote > angle brackets
1 participant