Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape Numeric Aliases & Refactor YAML Title Alias Logic #757

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Escape Numeric Aliases & Refactor YAML Title Alias Logic #757

merged 5 commits into from
Jun 14, 2023

Conversation

pjkaufman
Copy link
Collaborator

Fixes #747

Changes Made:

  • Refactored logic in the YAML Title Alias rule to make things easier to work with in the future
    • The title retrieval and new alias value creation logic were moved to their own methods
  • Added tests for 2 scenarios in question to make sure they get escaped
  • Added an isNumeric method for checking if a string is a number

@pjkaufman pjkaufman added bug Something isn't working code cleanup labels Jun 13, 2023
@pjkaufman pjkaufman self-assigned this Jun 13, 2023
@pjkaufman pjkaufman changed the title Escape Numeric Aliases & Refactor YAML Title Alias Logic Escape Numeric Aliases & Refactor YAML Title Alias Logic Jun 13, 2023
@pjkaufman pjkaufman merged commit 4f24c82 into platers:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Numerical aliases need to be quoted to work
1 participant
@pjkaufman