Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned Up List Item Text Update Logic #721

Merged
merged 3 commits into from
May 14, 2023
Merged

Conversation

pjkaufman
Copy link
Collaborator

Changes Made:

  • Fixed an example that actually included codeblocks to no longer include them
  • Refactored and reworked update list item text logic to let unist do the work of finding the list items and then getting the paragraph kids of them as the actual text for them instead of all text inside a list item

… simpler while also fixing an issue with affecting things other than list item text when running the logic against it
@pjkaufman pjkaufman self-assigned this May 14, 2023
@pjkaufman pjkaufman marked this pull request as draft May 14, 2023 12:39
@pjkaufman
Copy link
Collaborator Author

I need to check to see why the text of the task itself is including the task list indicator. It should not be included, which implies that I need to add the column and offset together to get the position, but I am not certain of this yet. I will test somethings out and see what happens.

…d of doing a check on each actual instance of the function iteration
@pjkaufman pjkaufman marked this pull request as ready for review May 14, 2023 17:22
@pjkaufman pjkaufman merged commit ae476f2 into platers:master May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant