Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed a Couple of SettingsTab Properties to Try to Fix Navigation Menu Issues #566

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

pjkaufman
Copy link
Collaborator

Relates to #564 #565

Changes Made:

  • renamed navEl since it conflicts with an unexported property on the settings tab used by Obsidian
  • renamed settingsEl just to make sure it does not also conflict
  • Updated the version info for a patch

I did see that the issue with Linter always being highlighted in the plugin section of the settings tab went away after the change.

@pjkaufman pjkaufman added the bug Something isn't working label Dec 22, 2022
@pjkaufman pjkaufman self-assigned this Dec 22, 2022
@pjkaufman pjkaufman merged commit dff3782 into platers:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant