Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Heading Placed on Same Line as Frontmatter When File is Just Frontmatter #514

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Fix Heading Placed on Same Line as Frontmatter When File is Just Frontmatter #514

merged 2 commits into from
Nov 25, 2022

Conversation

pjkaufman
Copy link
Collaborator

Fixes #513

Changes Made:

  • Added a UT to make sure we cover the scenario in question
  • Made sure to add a new line character before the heading if the heading was to be placed after the ending of the current document since that would mean there is no newline after the frontmatter

@pjkaufman
fixed an issue with the title getting inserted on the same line as th…
80a4f08 
…e yaml frontmatter ended if it was the only thing in the file when file name heading tried to insert the heading
@pjkaufman
added the comment referencing the bug that was fixed by the UT
d443bf6
@pjkaufman pjkaufman added bug Something isn't working markdown General Markdown or Markdown related issue or feature labels Nov 25, 2022
@pjkaufman pjkaufman self-assigned this Nov 25, 2022
@pjkaufman pjkaufman merged commit 3916312 into platers:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect addition of H1 when the note only contains front-matter
1 participant
@pjkaufman