New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Fix Performance for Parsing Larger Files by Using Regex instead of Remark for Tables #491

Merged

pjkaufman merged 1 commit into platers:master from pjkaufman:performance-updates

Nov 10, 2022

Collaborator

pjkaufman commented Nov 10, 2022 •

edited

Loading

Fixes #458

Changes Made:

Swapped out remark parser for tables which was taking 77 minutes to parse a 5.8k line file to regex instead which allows the time to be around 1 second to parse the file
Updated the UTs and dependencies accordingly


          fixed UTs

3dcb68c

pjkaufman added the bug label

pjkaufman self-assigned this

pjkaufman merged commit 19a247c into platers:master

pjkaufman deleted the performance-updates branch

November 10, 2022 13:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug