Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Bare URLs Add Smart Typography as Acceptable Wrapping Characters and Ignore Inline Code #471

Merged
merged 2 commits into from
Nov 2, 2022
Merged

No Bare URLs Add Smart Typography as Acceptable Wrapping Characters and Ignore Inline Code #471

merged 2 commits into from
Nov 2, 2022

Conversation

pjkaufman
Copy link
Collaborator

Fixes #469

Changes Made:

  • Refactored the logic for determining if a URL is acceptably escaped to make it simpler visually
  • Added UTs to help avoid issues with this down the road
  • Updated example to make sure it would pass the test and make it corroborate the functionality of the rule as it was changed

@pjkaufman pjkaufman added bug Something isn't working enhancement New feature or request labels Nov 2, 2022
@pjkaufman pjkaufman self-assigned this Nov 2, 2022
@pjkaufman pjkaufman merged commit 5624359 into platers:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: No Bare URLs Breakages in Code Block and Smart Typography
1 participant
@pjkaufman