Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Escape Logic and Fix Issue with Failure to Escape Titles and Aliases #461

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Update Escape Logic and Fix Issue with Failure to Escape Titles and Aliases #461

merged 3 commits into from
Oct 26, 2022

Conversation

pjkaufman
Copy link
Collaborator

Fixes #439

Changes Made:

  • Updated the UTs for yaml title and yaml title alias
  • Refactored escape logic to yaml.ts to make sure it could be reused by other services
  • Made sure that rules like yaml title and yaml title alias as well as forcing the use of escape characters all use the same logic for escaping values

@pjkaufman pjkaufman added bug Something isn't working code cleanup labels Oct 26, 2022
@pjkaufman pjkaufman self-assigned this Oct 26, 2022
@pjkaufman pjkaufman merged commit 1abeb1d into platers:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pjkaufman pjkaufman

Labels
bug Something isn't working code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Titles with special characters not getting escaped in aliases
1 participant
@pjkaufman