Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Link Parsing #243

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Update Link Parsing #243

merged 4 commits into from
Jun 29, 2022

Conversation

pjkaufman
Copy link
Collaborator

Updated the link parsing to be more robust than before. Before it would often include characters outside the link if the link was followed by a parentheses after the end of the link. To fix this, I let remark handle finding the regular links and just identified wiki links. The downside of this is that images/transclusion of regular makdown links is ignored for the sake of removing spaces in link text. We can add that by including images in the types to pull back from remark.

Changes Made:

  • Updated regular markdown link identification to go through remark-js
  • Added a UT for a scenario I noticed was not working around cleaning up whitespace
  • Updated example to show translusion is not affected by removing spaces around links
  • Updated documentation to include updated name for a method that was previously updated

@pjkaufman pjkaufman merged commit 17dc370 into platers:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant