Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Tags for Chinese and English Character Spacing #235

Merged
merged 12 commits into from
Jun 22, 2022

Conversation

pjkaufman
Copy link
Collaborator

Fixes #234

It was reported that tags that have both English and Chinese were getting spaces added between the Chinese and English. To fix this, the logic around ignoring information was updated to also ignore tags to protect against similar issues in other rules.

Changes Made:

  • Renamed method for ignoring YAML, code blocks, and links since tags were added to the mix
  • Added logic to ignore tags if the method is used
  • Added a test to make sure that we do not accidentally create this issue in the future

@pjkaufman pjkaufman added the bug Something isn't working label Jun 22, 2022
@pjkaufman pjkaufman self-assigned this Jun 22, 2022
@pjkaufman pjkaufman merged commit 5210cbe into platers:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I checked the option "Space between Chinese and English or numbers", the tag is changed
1 participant