Fix: Paste with a URL not Working Consistently #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1145
There was an issue with pasted text for list items and URLs not consistently being recognized as URLs. The problem seems to have been that we were looking for a URL anywhere in the pasted text. I looked into whether or not that was necessary for Auto Title Link and Paste URL into Selection, but neither of them seems to allow an https or file link just anywhere (I could have misread it though). This means that we should also be doing a similar check that the whole pasted logic is a URL before deciding to skip it.
Changes Made: