Fix: yaml-title-alias Does Not Respect Multiline Format when Initially Empty with Preserve Existing Format Used
#1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when yaml title alias is used with preserve existing format and the current value is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1085
There was a reported issue where
yaml-title-aliasdid not seem to be working when the aliases section was empty, default aliases section style was multiline, and the setting for preserving the style of the aliases section was set to true. The fix was to make sure that we assume that[]is not tied to any one type. So if that is the value for aliases and the default style for aliases is multiline, we will assume it is meant to be a multiline array.Changes Made: