Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading Blank Lines: Make Sure Tags on The Line Before a Heading Gets a Blank Line Added when Bottom=false #1008

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

pjkaufman
Copy link
Collaborator

Fixes #993

There was an issue where Bottom=false and the line before a heading had a # in it.
For example:

# Heading 1
Lorem ipsum.

## Heading 2
Woah, cool text here. #reallycool
## Heading 3

would not get changed.

After the change it now looks like:

# Heading 1
Lorem ipsum.

## Heading 2
Woah, cool text here. #reallycool

## Heading 3

Changes Made:

  • Added a test for the scenario in question
  • Updated the regex for when Bottom=false to make sure that it only does not allow a line to start with # for adding a blank line before a heading

pjkaufman and others added 2 commits February 5, 2024 10:55
@pjkaufman pjkaufman added bug Something isn't working markdown General Markdown or Markdown related issue or feature labels Feb 5, 2024
@pjkaufman pjkaufman self-assigned this Feb 5, 2024
@pjkaufman pjkaufman merged commit 0e704c5 into platers:master Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: heading-blank-lines does not work properly if the line preceding a header has a #
1 participant