Optional distinct added for filtered_collection to sort nested associations #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions with ransack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional distinct for sorting nested associations with ransack gem, since you have to set .result(distinct: false) for it to work.
For example, given an endpoint where we have many users, and each user can have many posts, and each post have a title column:
/users?q[s]=post_title ascshould sort all users based on the title of their posts, but it won't work because of (distinct: true).But if we set distinct to false, it will sort properly.
This way, when we want to sort with an association, in out controller we would do:
respond_with filtered_collection(User.all, false)