feat(i18n): remove i18n fallback config in prod #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexto
Potassium agrega i18n y
es-CLoencomo idioma por defecto. También agrega un par de fallbacks.Este PR
Este PR saca una configuración que se agregaba por defecto en
production.rb,config.i18n.fallbacks = true. Potassium ya configura los fallbacks en elapplication.rbcon otro valor, entonces estaba pasando que la configuración en producción y local eran diferentes.En la mayoría de los casos no es mucho problema, ya que en ambos toma el idioma seleccionado,
es-CL. Pero en caso de no tener una traducción, en local pasaba a los fallbacksesyen, mientras que en producción tiraba un error de translation missing