feat(recipe): add rubocop-platanus to recipe #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
difernandez
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexto
En Platanus es un desafío grande transmitir las decisiones que vamos tomando en relación a estándares y buenas prácticas de desarrollo. Por ej: si empezamos a usar jobs en vez de comandos, ¿cómo hacemos que este cambio se empiece a aplicar en todos los proyectos? o si está prohibido usar una gema x, ¿cómo le avisamos a la gente que use una alternativa?
Basado en esta investigación, descubrimos que es factible transmitir esta información usando reglas custom de Rubocop.
Ya se creó la gema rubocop-platanus como una extension de rubocop con estas reglas custom.
Que se esta haciendo
Se agrega la gema rubocop-platanus y su configuración al recipe de nuevos proyectos.