Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rubocop): add run_test! example group for swagger in rpsec #379

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

GabrielLyonB
Copy link
Contributor

@GabrielLyonB GabrielLyonB commented Jul 19, 2021

Objective

Include run_test! to Rspec example groups for swagger API documentation/testing.
This is mentioned in issue #362.

@GabrielLyonB GabrielLyonB requested a review from ldlsegovia July 19, 2021 21:18
@jgmontoya
Copy link
Contributor

Shouldn't this be conditionally added based on the API recipe?
I think swagger is only included with the "REST (with Power API)" option.

(Also, please remember to update the changelog)

@ldlsegovia
Copy link
Collaborator

Shouldn't this be conditionally added based on the API recipe?
I think swagger is only included with the "REST (with Power API)" option.

(Also, please remember to update the changelog)

I think the extra complexity is not necessary. It doesn't matter if swagger is not there and it's not used.
+1 to update the changelog

@GabrielLyonB GabrielLyonB force-pushed the add-run-test-for-swagger-example-test branch from bb0ba1d to 6458070 Compare July 23, 2021 12:31
@GabrielLyonB
Copy link
Contributor Author

GabrielLyonB commented Jul 23, 2021

Shouldn't this be conditionally added based on the API recipe?
I think swagger is only included with the "REST (with Power API)" option.
(Also, please remember to update the changelog)

I think the extra complexity is not necessary. It doesn't matter if swagger is not there and it's not used.
+1 to update the changelog

I added what @jgmontoya requested. If you think it should be directly in the .rubocop.yml file instead of conditionally added, i can change it again.

@GabrielLyonB GabrielLyonB requested a review from ldlsegovia July 23, 2021 12:34
@GabrielLyonB GabrielLyonB merged commit af3b2ef into master Jul 26, 2021
@GabrielLyonB GabrielLyonB deleted the add-run-test-for-swagger-example-test branch July 26, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants