Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(assets/app/js/app.spec.js): remove deprecated method #376

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

jgmontoya
Copy link
Contributor

The isVueInstance method is deprecated and triggers a warning.
The proposed way tests exactly the same but avoids the warning message.

Copy link
Contributor

@difernandez difernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the link to this PR at the end of the Changelog entry?

@jgmontoya jgmontoya force-pushed the chore/test-deprecated-method branch from ee56d8a to a7d0341 Compare July 12, 2021 14:09
@jgmontoya jgmontoya force-pushed the chore/test-deprecated-method branch from a7d0341 to 0858928 Compare July 12, 2021 14:10
@jgmontoya jgmontoya merged commit aac966c into master Jul 12, 2021
@jgmontoya jgmontoya deleted the chore/test-deprecated-method branch July 12, 2021 14:26
@difernandez difernandez mentioned this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants